ci: add --ignore-scripts to npm tool installs (Sonar) - #169
Merged
Conversation
|
Claude finished @achoimet's task in 1m 38s —— View job Review
Summary: Small, well-scoped change — adds Findings:
No changes requested — looks good to merge from a correctness/security standpoint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SonarCloud flags npm installs in workflows that omit
--ignore-scriptsas major vulnerabilities ("Omitting --ignore-scripts allows lifecycle scripts to run during package installation") — this is what actually failed the platform nightly quality gate, not version pinning. Adds--ignore-scriptsto the npm self-install (the npm package has no lifecycle scripts; verified 12.0.2 installs and runs correctly with the flag).