Skip to content

fix: keep time-dependent oracle survey-only - #205

Merged
jan-kubica merged 1 commit into
mainfrom
fix/oracle-future-birthdate
Aug 30, 2026
Merged

fix: keep time-dependent oracle survey-only#205
jan-kubica merged 1 commit into
mainfrom
fix/oracle-future-birthdate

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Summary

  • keep the stdnum-js Norwegian birth-number comparison in survey mode
  • prevent an ambient wall-clock rule from making deterministic validation CI change by date

Root cause

stdnum-js@1.12.6 calls isValidDate(..., true) and rejects otherwise valid birth numbers whose encoded date is after the runner clock. Stella and python-stdnum validate the calendar date without ambient time. The comparison remains useful ecosystem evidence, but it is not an equivalent release gate.

Remote CI is the validation source.

CC on behalf of jan-kubica

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 51 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 81cd12e4-55a4-46b5-ae27-8df118c58fd9

📥 Commits

Reviewing files that changed from the base of the PR and between 3e87960 and 7f80ae3.

📒 Files selected for processing (1)
  • scripts/oracle.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T19:22:59.343025Z 7f80ae3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jan-kubica
jan-kubica merged commit 8255c43 into main Aug 30, 2026
14 checks passed
@jan-kubica
jan-kubica deleted the fix/oracle-future-birthdate branch August 30, 2026 19:27
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant