Conversation
…-protocol#294) - Add new 'changelog' job to CI workflow that runs on every PR - Verify source changes (intent_settlement/src, proof_registry/src) have corresponding CHANGELOG.md updates - Provide 'no-changelog-needed' label escape hatch for test-only/comment-only changes - Update CONTRIBUTING.md with documentation on the new check - Add CHANGELOG entry documenting the enforcement
…lar-vortex-protocol#295) - Create scripts/e2e-test.sh for end-to-end testing against local Soroban network - Add 'integration-test' CI job that runs E2E test on every PR - Test full lifecycle: deploy → initialize → register_solver → submit_intent → accept_intent → fill_intent - Uses Docker to run local Soroban standalone network with friendbot funding - Document test in CONTRIBUTING.md with instructions for local debugging - Add CHANGELOG entry for the new integration test capability
…vortex-protocol#296) - Create .github/CODEOWNERS mapping major repository areas to owners/teams - Maps: intent_settlement/, proof_registry/, solver_registry/, indexer/, docs/, CI/workflows - Establish fallback owner for unmapped paths - Document code ownership process in CONTRIBUTING.md - Include instructions for contributors to become owners of specific areas - Add CHANGELOG entry for review-routing infrastructure
…elocked changes (issue stellar-vortex-protocol#297) - Create GOVERNANCE.md documenting the protocol governance process - Establish minimum 3-business-day discussion window before proposals - Define what requires a proposal: propose_* calls, set_config, upgrades - Document emergency exception for pause() in incident response - Create GitHub issue template for governance proposals - Link governance from CONTRIBUTING.md and README.md - Update CHANGELOG with new governance documentation
|
@usman222nuhu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…296-297 # Conflicts: # .github/workflows/ci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce governance, review routing, and integration testing infrastructure
Summary
Adds four complementary infrastructure improvements for CI/CD, code review routing, and protocol governance:
CONTRIBUTING.mdCHANGELOG-update requirement via a CI check #294): Automated check that source file changes include CHANGELOG updates, withno-changelog-neededlabel escape hatch for exempt changes.CODEOWNERSfile establishing review-routing across the repository #296):.github/CODEOWNERSmaps repository areas to owners; PRs automatically request relevant reviewers.GOVERNANCE.mdformalizes RFC discussion window (3 business days minimum) before on-chain proposals; includes proposal issue template.Changes
.github/workflows/ci.yml: Addchangelogandintegration-testjobsscripts/e2e-test.sh: End-to-end test script for local Soroban network.github/CODEOWNERS: Review routing for all major repository areasGOVERNANCE.md: Protocol governance process and decision framework.github/ISSUE_TEMPLATE/governance-proposal.md: Structured proposal templateCONTRIBUTING.md: Document all new processes (changelog, E2E test, code ownership, governance)README.md: Cross-reference governance from contributing sectionCHANGELOG.md: Document all four infrastructure additionsCloses
Closes #294
Closes #295
Closes #296
Closes #297