Parallelize in-memory state update with bucket list operations.#5284
Open
dmkozh wants to merge 1 commit into
Open
Parallelize in-memory state update with bucket list operations.#5284dmkozh wants to merge 1 commit into
dmkozh wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce ledger-close latency by overlapping (1) bucket list updates and (2) in-memory Soroban state updates during LedgerManagerImpl::finalizeLedgerTxnChanges, based on the assumption that these updates touch independent data structures.
Changes:
- Run
BucketManager::addHotArchiveBatchasynchronously (when applicable) instead of inline. - Run
ApplyState::updateInMemorySorobanStateasynchronously, overlapping it withaddLiveBatchand module-cache updates. - Add
<future>include to support the newstd::asyncusage.
dmkozh
force-pushed
the
ledger_upd_par
branch
3 times, most recently
from
87251b5 to
085504d
Compare
SirTyson
previously approved these changes
Jun 10, 2026
SirTyson
left a comment
SirTyson
left a comment
Contributor
There was a problem hiding this comment.
One area for code hardening, otherwise LGTM
dmkozh
force-pushed
the
ledger_upd_par
branch
2 times, most recently
from
1b3f7b7 to
cd3910b
Compare
During ledger close, run addHotArchiveBatch, addLiveBatch and updateInMemorySorobanState concurrently. They modify independent data structures and so need no synchronization.
SirTyson
approved these changes
Jun 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parallelize in-memory state update with bucket list operations.
During ledger close, run addHotArchiveBatch, addLiveBatch and updateInMemorySorobanState concurrently. They modify independent data structures and so there is no need for synchronization.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)