🧭 Simplified SDEX navbar explanation#2435
Open
JFWooten4 wants to merge 2 commits into
Open
Conversation
Co-authored-by: Codex <noreply@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Learn navigation and the SDEX liquidity pools doc metadata so first-time readers see “Stellar Decentralized Exchange” (and the SDEX acronym) spelled out more explicitly in the navbar and page title.
Changes:
- Expanded the doc’s
title,sidebar_label, and H1 to spell out “Stellar Decentralized Exchange”. - Updated the Learn navbar dropdown item label to “Stellar Decentralized Exchange (SDEX)”.
- Changed the doc’s
sidebar_positionvalue (which affects sidebar ordering).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/learn/fundamentals/liquidity-on-stellar-sdex-liquidity-pools.mdx | Expands SDEX/DEX naming in front matter and H1; also changes sidebar ordering via sidebar_position. |
| config/theme/navbar.ts | Updates Learn dropdown label to spell out “Stellar Decentralized Exchange (SDEX)”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| title: "Liquidity Pools on the Stellar Decentralized Exchange: Provide Liquidity and Enable Asset Swaps" | ||
| sidebar_label: "Stellar Decentralized Exchange" | ||
| description: "Learn how liquidity pools enable trading on the Stellar Decentralized Exchange. Understand how they work, provide liquidity, and enable decentralized asset swaps on the network." | ||
| sidebar_position: 42 |
Contributor
Author
There was a problem hiding this comment.
Yes, I think this looks a lot better vertically near the Stellar Data Structures and SCP headings (they approximately match similar widths) instead of leaving this section hanging off at the end like in the PR screenshot from prod (modified).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For readers first coming across Stellar, they may not know what the SDEX is. Other acronym concepts such as SCPU are spelled out in the menubar before having a parenthesis notation:
However, the SDEX doesn't currently receive the same treatment. It's an important concept which encompasses a lot of the network.
Along this line of thinking, this PR also spells out DEX in the page title since the acronym may be unfamiliar and is subsequently explained and defined in the actual doc page.
Lastly, this maintains the sidebar practice of spelling it out without the acronym: