Conversation
Use typed TypeSafe requests to rank installed skills and verify a bounded shortlist before text tasks. Keep routing opt-in, preserve the catalog, and fail open within one shared deadline. Include prompt preparation in session cancellation, stop routing during disposal, and document external data, billing, and the limits of upstream efficiency evidence.
ZenAlexa
reviewed
Sep 22, 2026
ZenAlexa
left a comment
There was a problem hiding this comment.
I ran the three Jev routing suites: 215 tests passed. The CLI bootstrap test passed. pnpm run check passed all repository checks on Node 22.23.2.
The cancellation path is wired from the per-run controller through before_agent_start and runtime shutdown. The tests cover late HTTP responses, deferred JSON bodies, excerpt reads, direct session disposal, runtime disposal ordering, and a fresh prompt after cancellation. The request body keeps the external payload limited to the documented request and skill metadata or excerpts.
I have no actionable finding on this head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step Code can miss a relevant skill or read an unnecessary one when choosing from a large catalog. Add optional Jev suggestions before text requests, enabled with
STEP_JEV_SKILL_ROUTING=1and a separate TypeSafe API key.before_agent_startin the existing cancellable session lifecycle and expose its existingctx.signal. Cancelling or disposing the session stops pending routing and prevents later requests or coding-model startup. Runtime shutdown settles cancellation before invalidating extension contexts.Validation on Node 22.19.0:
npm run checkandpnpm run build:offlinepassed../test.shpassed the script tests and other workspace packages; coding-agent reported 275 passed files / 3,671 passed tests, plus the single baseline failure below. The recursive command stops at that failure, so CLI was run separately against the final build../test.shis not fully green in this environment:test/startup-session-name.test.ts:117hits its existing 10-second child-process timeout (expected exit 1, received null after SIGKILL). The same test fails on the clean base commite411b1ab497b6ef773a49b86d5237d3c2a4b643c. A longer observation confirms that the startup child exits with code 1 after 27.03 seconds and writes the expected session name. This change leaves the existing timeout and assertions intact.TypeSafe transport is mocked in automated tests; live Jev accuracy, production latency, Step Code token savings, and usage growth have not been measured.