Skip to content

Add STM32C5 support to I3C with dual HAL V1/V2 compatibility#3023

Merged
fpistm merged 2 commits into
stm32duino:mainfrom
Aymane-ST:c5_i3C_support
Jul 20, 2026
Merged

Add STM32C5 support to I3C with dual HAL V1/V2 compatibility#3023
fpistm merged 2 commits into
stm32duino:mainfrom
Aymane-ST:c5_i3C_support

Conversation

@Aymane-ST

Copy link
Copy Markdown
Contributor

This PR adds dual HAL V1 / HAL V2 support to the I3C library while preserving the existing public API as much as possible.

  • the implementation keeps V1 and V2 paths explicit with local #if defined(USE_HALV2_DRIVER) blocks
  • existing behavior and public API were preserved whenever possible
  • a few internal/public helper types were introduced where needed to avoid exposing HAL-specific structures in examples

@Aymane-ST Aymane-ST added this to the 3.0.0 milestone Jul 15, 2026
@Aymane-ST
Aymane-ST requested a review from fpistm July 15, 2026 12:21
@Aymane-ST Aymane-ST self-assigned this Jul 15, 2026
@Aymane-ST Aymane-ST added enhancement New feature or request fix 🩹 Bug fix labels Jul 15, 2026
@fpistm fpistm removed the fix 🩹 Bug fix label Jul 15, 2026
@Aymane-ST Aymane-ST changed the title Add STM32C5 support with dual HAL V1/V2 compatibility Add STM32C5 support to I3C with dual HAL V1/V2 compatibility Jul 15, 2026

@fpistm fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round.

Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/examples/Controller_Target/TargetReceive/TargetReceive.ino Outdated
Comment thread libraries/SrcWrapper/src/HAL/stm32yyxx_util_i3c.c Outdated
Comment thread libraries/I3C/src/I3C_I2C.cpp Outdated
@github-project-automation github-project-automation Bot moved this from In progress to Needs review in STM32duino libraries Jul 15, 2026
@Aymane-ST
Aymane-ST force-pushed the c5_i3C_support branch 3 times, most recently from 94853b6 to 0a3558e Compare July 16, 2026 08:25
@fpistm fpistm mentioned this pull request Jul 16, 2026
16 tasks
@fpistm
fpistm marked this pull request as ready for review July 16, 2026 13:33
Comment thread libraries/I3C/examples/Controller_Target/TargetReceive/TargetReceive.ino Outdated
Comment thread libraries/I3C/src/I3C.h Outdated
Comment thread libraries/I3C/src/I3C.h Outdated
Comment thread libraries/I3C/src/I3C.h Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp
Comment thread libraries/I3C/src/I3C.cpp Outdated
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>

@fpistm fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested with Nucleo C562RE and stm32duino/LPS22DF#5

@github-project-automation github-project-automation Bot moved this from Needs review to Reviewer approved in STM32duino libraries Jul 20, 2026
@fpistm
fpistm merged commit 478a55f into stm32duino:main Jul 20, 2026
28 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in STM32duino libraries Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants