Skip to content

fix: fetch server configuration on client initialization for invite_only servers #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riscdanger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fetch server configuration on client initialization for invite_only servers #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ export class Client extends AsyncEventEmitter<Events> {
#setConnectionFailureCount: Setter<number>;
#reconnectTimeout: number | undefined;

#configurationFetched: boolean;

/**
* Create Stoat.js Client
*/
Expand Down Expand Up @@ -242,14 +244,13 @@ export class Client extends AsyncEventEmitter<Events> {
};

this.configuration = configuration;
this.#configurationFetched = false;

this.api = new API({
baseURL: this.options.baseURL,
});

const [configured, setConfigured] = createSignal(
configuration !== undefined,
);
const [configured, setConfigured] = createSignal(false);
this.configured = configured;
this.#setConfigured = setConfigured;

Expand Down Expand Up @@ -339,13 +340,13 @@ export class Client extends AsyncEventEmitter<Events> {
}

/**
* Fetches the configuration of the server if it has not been already fetched.
* Fetches the configuration from the server if not already fetched.
*/
async #fetchConfiguration(): Promise<void> {
if (!this.configuration) {
this.configuration = await this.api.get("/");
this.#setConfigured(true);
}
if (this.#configurationFetched) return;
this.configuration = await this.api.get("/");
this.#configurationFetched = true;
this.#setConfigured(true);
}

/**
Expand Down