fix: Empty screen for signed user#154
Open
HornedHeck wants to merge 2 commits intostoatchat:mainfrom
Open
Conversation
Ensure configuration fetch is finished before trying to use it. Signed-off-by: HornedHeck <43969792+HornedHeck@users.noreply.github.com>
Taureon
reviewed
Apr 29, 2026
Signed-off-by: HornedHeck <43969792+HornedHeck@users.noreply.github.com>
Taureon
reviewed
Apr 30, 2026
| * Connect to Revolt | ||
| */ | ||
| connect(): void { | ||
| void this.#connect().catch((error) => this.emit("error", error)); |
There was a problem hiding this comment.
the void operator here looks optional too
Suggested change
| void this.#connect().catch((error) => this.emit("error", error)); | |
| this.#connect().catch((error) => this.emit("error", error)); |
|
ACK 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG
When I try to open stoat-for-web for self-hosted instance for already signed in user, I see empty screen.
REASON
Client.ts tries to connect to WebSocket by the url specified in the configuration. However it does not await for results of configuration sync in constructor. It leads to the fact that
configuration.wsis empty and is not value WebSocket url.STEPS:
EXPECTED
Signed-in experience is visible and accessible.