fix: derive file extension from output_format in generate_image#502
Open
wangwangbobo wants to merge 3 commits into
Open
fix: derive file extension from output_format in generate_image#502wangwangbobo wants to merge 3 commits into
wangwangbobo wants to merge 3 commits into
Conversation
wangwangbobo
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
generate_imagewas saving files with hardcoded.pngextension regardless of the requestedoutput_format. JPEG bytes were landing in.pngfiles.Fix: Derive the file extension from
output_formatparameter (jpeg→.jpg, png→.png).Changes:
ext = "jpg" if output_format == "jpeg" else output_formatbase_image_pathand the collision-loopimage_pathto use{ext}3 lines changed, no new dependencies.