fix(editor): normalize paths for consistent cache keys#503
Open
wangwangbobo wants to merge 1 commit into
Open
Conversation
Use os.path.abspath() alongside expanduser() to ensure the same file always maps to the same cache key, regardless of relative vs absolute path format. Fixes strands-agents#345
wangwangbobo
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix editor tool cache using non-normalized paths (fixes #345).
Problem
The editor tool cache uses raw path strings as keys, so the same file accessed via relative vs absolute paths creates separate cache entries. This causes stale content to be returned after modifications.
Solution
Normalize paths with at the start of the editor function, ensuring consistent cache keys regardless of path format.
Changes
Impact