fix(browser): make get_html truncation configurable instead of hard-coded 1000 chars#504
Open
wangwangbobo wants to merge 1 commit into
Open
Conversation
…oded 1000 chars - Add optional max_length parameter to GetHtmlAction (defaults to None = full HTML) - Remove hard-coded 1000-char truncation, return full HTML by default - Fixes strands-agents#407
wangwangbobo
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #407 - hard-coded 1,000-character truncation returns broken HTML fragments.
Changes
Why
The hard-coded 1000-char limit makes unusable for any pipeline that needs full page content (HTML-to-markdown conversion, etc.). This is a backward-compatible change - existing callers who want truncation can pass explicitly.
Changes