fix(automation): staging bring-up follow-ups (email rendering, scan summary, deploy robustness, tags)#70
Merged
Conversation
…loy script workflows:deploy now tags every workflow with community-hub plus the environment tag (staging, or production when namespace=strapi) via PUT /workflows/:id/tags, creating any missing tag. Applied to the staging set. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…t nodes Build Summary read the 'Wait for All Stages' merge output (which combines the two PATCH responses and has no stage/result keys), so its pick() returned null for both stages and every summary field came out null. Read the dependency + AI results directly from the Format Package Scan Result / Format AI Result nodes instead; the merge stays only to gate timing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…flows Re-link executeWorkflow/errorWorkflow references to the target's ids BEFORE the create/update (push referenced sub-workflows first, seed ids from existing) — n8n rejects publishing an active workflow whose executeWorkflow target isn't published, so the old relink-in-a-second-pass failed on re-deploys against active instances. Also scope the tag pass to the deployed workflows only, so pre-existing workflows on a shared instance aren't tagged/overwritten. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The email-template body is Strapi richtext (markdown), but render-email dropped it raw into the HTML shell, so **bold**, > blockquotes, and paragraph breaks showed as literal text. Add a markdown->HTML converter in 'Wrap In Branded Shell' (bold/italic/inline-code/blockquote/headings/paragraphs + bare-URL autolink), HTML-escaping first so interpolated reviewer feedback can't inject markup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up fixes to #65 (multi-env automation deploy), found while bringing the workflows up on the staging n8n instance. All four are scoped to
apps/automation.Changes
feat: tag deployed workflows—workflows:deploynow tags every deployed workflow withcommunity-hub+ the environment tag (staging, orproductionwhen the namespace isstrapi) viaPUT /workflows/:id/tags, creating the tags if missing.fix: security-scan summary reads stage results from Format nodes— Build Summary read theWait for All Stagesmerge output (the combined PATCH responses, which have nostage/resultkeys), so every summary field came outnull. It now reads the dependency + AI results directly fromFormat Package Scan Result/Format AI Result; the merge stays only to gate timing.fix: deploy re-links before PUT + tags only deployed workflows— re-linkexecuteWorkflow → render-email/errorWorkflow → error-handlerto the target's ids before the create/update (push referenced sub-workflows first; seed ids from existing). n8n refuses to publish an active workflow whoseexecuteWorkflowtarget isn't published, so the old relink-in-a-second-pass failed on re-deploys against active instances. Also scope the tag pass to deployed workflows only, so pre-existing workflows on a shared instance aren't tagged/overwritten.fix: render email body markdown to HTML— the email-templatebodyis Strapi richtext (markdown), but render-email dropped it raw into the HTML shell, so**bold**,> blockquotes, and paragraph breaks showed as literal text. Added a markdown→HTML converter in Wrap In Branded Shell (bold / italic / inline-code / blockquote / headings / paragraphs + bare-URL autolink), HTML-escaping first so interpolated reviewer feedback can't inject markup.Verified
Deployed to the staging n8n via
workflows:deploy(12 updated, 0 failed, credentials preserved); security-scan now writes a populated summary and lifecycle emails render formatted. Tracking the AI-source-fetch gap separately in #69.🤖 Generated with Claude Code