Revert "Use 'git diff' instead of 'cargo tree'"#4
Merged
mulkieran merged 1 commit intostratis-storage:masterfrom Jul 14, 2025
Merged
Revert "Use 'git diff' instead of 'cargo tree'"#4mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran merged 1 commit intostratis-storage:masterfrom
Conversation
This reverts commit ea5d47a. Using 'git diff' is actually worse than using 'cargo tree'. In some situations, when checkout action checks out to a specified path, the git information is stripped, and so 'git diff' fails entirely reporting that the repository is not a git directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: stratis-storage/project#755