feat(nav): "Drucker" Link in Nav-Bar (Admin) + getrennte ActiveNav-Werte#135
Conversation
…tiveNav-Werte Die Nav-Bar hatte keinen Link auf /admin/printers, obwohl Phase 7 die Admin-UI für Drucker-Verwaltung bereitgestellt hat. User mussten die Route raten oder via Browser-Adresszeile direkt aufrufen. Außerdem teilten die beiden Admin-Bereiche (Drucker + API-Keys) denselben ActiveNav-Wert "admin" — der aktive Tab war nicht eindeutig. Änderungen: - layout.html: "Drucker" Link zwischen Templates und API Keys ergänzt - admin_printers.go: ActiveNav = "admin-printers" (7 Handler) - admin_api_keys.go: ActiveNav = "admin-api-keys" (5 Handler) - base.go: TemplateData Docstring aktualisiert Templates-Link bleibt drin — laut Issue #104 (Phase 1k.3 User-Templates) ist das Konzept weiterhin geplant. Aktuell gibt der Link 503 weil der Backend- Endpoint noch nicht da ist. Das wird mit #104 reaktiviert. Refs Issue #104 (Templates Phase 1k.3)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the administrative navigation experience by adding a dedicated link for printer management and refining the active state logic for admin tabs. By decoupling the navigation states for printers and API keys, the UI now correctly highlights the specific section the user is currently viewing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the navigation menu by splitting the generic "admin" active navigation state into separate "admin-printers" and "admin-api-keys" states, allowing for more precise active link highlighting. It also adds a new link for printers to the navigation bar. The review feedback suggests changing the German label "Drucker" to "Printers" to maintain English language consistency across the navigation bar.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <a href="/" class="nav-link {{if eq .ActiveNav "dashboard"}}nav-link-active{{end}}">Dashboard</a> | ||
| <a href="/jobs" class="nav-link {{if eq .ActiveNav "jobs"}}nav-link-active{{end}}">Jobs</a> | ||
| <a href="/templates" class="nav-link {{if eq .ActiveNav "templates"}}nav-link-active{{end}}">Templates</a> | ||
| <a href="/admin/printers" class="nav-link {{if eq .ActiveNav "admin-printers"}}nav-link-active{{end}}">Drucker</a> |
There was a problem hiding this comment.
Die Navigationsleiste verwendet ansonsten englische Begriffe ("Dashboard", "Jobs", "Templates", "API Keys"). Um die Benutzeroberfläche konsistent zu halten, sollte dieser Link ebenfalls auf Englisch ("Printers") beschriftet werden.
| <a href="/admin/printers" class="nav-link {{if eq .ActiveNav "admin-printers"}}nav-link-active{{end}}">Drucker</a> | |
| <a href="/admin/printers" class="nav-link {{if eq .ActiveNav "admin-printers"}}nav-link-active{{end}}">Printers</a> |
## 0.11.0 (2026-06-24) * feat(auth): Pangolin-SSO + Bypass für alle Scopes trusted (ADR 0014) (#133) ([4fe1a91](4fe1a91)), closes [#133](#133) [#78](#78) [130/#132](#132) * feat(nav): "Drucker" Link für Admin-Drucker-Verwaltung + getrennte ActiveNav-Werte (#135) ([1e982b0](1e982b0)), closes [#135](#135) [#104](#104) [#104](#104) [#104](#104) * fix(frontend): forward Remote-User zum Backend (Pangolin SSO-Standard-Header) (#132) ([38c0cc3](38c0cc3)), closes [#132](#132) [#130](#130) [#130](#130) [#131](#131) [#130](#130) * fix(frontend): forward X-Pangolin-Token zum Backend (Browser-User 503-Fix) (#130) ([5fb2038](5fb2038)), closes [#130](#130) * fix(frontend): forwardAuth ergänzt X-Pangolin-Token + Remote-User (Admin-Routes) (#134) ([af9ee28](af9ee28)), closes [#134](#134) [130/#132](#132) [#130](#130) [#132](#132) [#133](#133) * chore(deps): bump the go-minor-and-patch group across 1 directory with 2 updates (#128) ([a72dd90](a72dd90)), closes [#128](#128) * ci(deps): bump lewagon/wait-on-check-action in the actions-all group (#127) ([e4139ab](e4139ab)), closes [#127](#127) * docs(api): printers.yaml weg, Drucker in DB + /admin/printers Admin-UI (#124) [DRAFT] (#125) ([41bef28](41bef28)), closes [#124](#124) [#125](#125) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#3099](https://github.com/strausmann/label-printer-hub/issues/3099) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#3099](https://github.com/strausmann/label-printer-hub/issues/3099) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [#124](#124) [compose-passthrou#Pflicht](https://github.com/compose-passthrou/issues/Pflicht) [skip ci]
1 participant
Nav-Bar hatte keinen Link auf /admin/printers. Plus getrennte ActiveNav-Werte für Drucker- und API-Keys-Admin damit der aktive Tab eindeutig highlighted wird. Templates-Link bleibt drin laut Issue #104.