Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing the
cookieNamepassed touseCookieleaves the returned value pointing to the previous cookie. For example, switching fromuseCookie('cookieA')touseCookie('cookieB')continues to return cookie A's value even though the update and delete callbacks already target cookie B.Refresh the stored value in an effect whenever
cookieNamechanges, returningnullwhen the new cookie does not exist. Add regression tests for switching names, missing cookies, switching back, and update/delete callbacks after switching. Document the behavior.Fixes #2590.
Type of change
Validation
useCookietests pass, with 100% statement, branch, function, and line coverage forsrc/useCookie.ts.Checklist