feat(firehose): add async emission mode, shutdown drain, and cursor writing#2
Draft
Copilot wants to merge 3 commits into
Draft
feat(firehose): add async emission mode, shutdown drain, and cursor writing#2Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…riting Bump firehose-tracer to 5.1.0 which adds EmissionMode, ShutdownHandle, and cursor file support. Add FirehoseArgs CLI args in a separate crate (reth-firehose) to minimize future merge conflicts. Wire shutdown handle drain into the node lifecycle via on_component_initialized hook. Vendor rbase64 with global allocator removed to avoid jemalloc conflict. Agent-Logs-Url: https://github.com/streamingfast/reth/sessions/92ea0d4c-b97f-43b8-b6de-cb95c46058f1 Co-authored-by: maoueh <123014+maoueh@users.noreply.github.com>
Agent-Logs-Url: https://github.com/streamingfast/reth/sessions/92ea0d4c-b97f-43b8-b6de-cb95c46058f1 Co-authored-by: maoueh <123014+maoueh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement feature with minimal future diffs
feat(firehose): add async emission mode, shutdown drain, and cursor writing
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the async emission feature from PR #1 onto
release/reth-1.xwith a strategy to minimize future merge conflicts: all custom code lives in separate files/crates.Note: This PR's base branch should be changed to
release/reth-1.x.Changes
crates/firehose/— newreth-firehosecrate containing:FirehoseArgsclap struct (--firehose.emission-mode,--firehose.channel-capacity,--firehose.live-threshold,--firehose.cursor-path)init_tracer(Config) -> Option<ShutdownHandle>with process-wideOnceLockbin/reth/src/main.rs— minimal diff wrapping the existing node launch:vendor/rbase64/— patched rbase64 2.0.3 with#[global_allocator](MiMalloc) removed; wired via[patch.crates-io]firehose-tracer5.0.0 → 5.1.0 (addsEmissionMode,ShutdownHandle, cursor file support)Deliberately not ported
Gap detection, re-trace on async gap, and everything related to startup re-emission — per requirements, only cursor writing is included.
Original prompt
Created from VS Code.