Skip to content

build(deps): update signature requirement from 2 to 3#56

Open
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/cargo/signature-3
Open

build(deps): update signature requirement from 2 to 3#56
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/cargo/signature-3

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 3, 2026

Updates the requirements on signature to permit the latest version.

Commits
  • 9488e7e signature v3.0.0 (#2400)
  • 2917d19 build(deps): bump the all-deps group across 1 directory with 4 updates (#2398)
  • 7b029ba signature: add AsyncVerifier, AsyncMultipartVerifier, `AsyncDigestVerifie...
  • c6d4dd7 elliptic-curve v0.14.0-rc.32 (#2399)
  • f2069a2 elliptic-curve: bump pkcs8 to v0.11 (#2397)
  • 8250383 elliptic-curve: bump pkcs8 to v0.11.0-rc.12 (#2396)
  • 54e464f signature: remove long-winded intro section in rustdoc (#2392)
  • 5cb62a4 signature: enable/fix workspace-level lints; reformat docs (#2391)
  • 375378f elliptic-curve: consistent PKCS#8 / SEC1 naming in secret_key.rs (#2388)
  • 30a48ab elliptic-curve: add mul_by_generator(_vartime) benchmarks (#2389)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [signature](https://github.com/RustCrypto/traits) to permit the latest version.
- [Commits](RustCrypto/traits@signature/v2.0.0...signature-v3.0.0)

---
updated-dependencies:
- dependency-name: signature
  dependency-version: 3.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels May 3, 2026
@polaz
Copy link
Copy Markdown
Member

polaz commented May 11, 2026

@copilot verify what is broken and try to fix

Copy link
Copy Markdown

Copilot AI commented May 11, 2026

@copilot verify what is broken and try to fix

Fixed in cd0c175. The breakage was a signature v2/v3 trait mismatch in src/xmldsig/signature.rs: the code imported verifier traits from direct signature v3, but the RSA/ECDSA verifying keys implement the signature v2 traits re-exported by rsa/ecdsa. I switched the imports to the rsa::signature re-exports and verified locally with cargo fmt --all -- --check, cargo clippy --all-features --all-targets -- -D warnings, cargo build --all-features, cargo test --all-features, and cargo test --doc --all-features.

Copilot AI requested a review from polaz May 11, 2026 13:06
Copilot finished work on behalf of polaz May 11, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants