Upload profiling figures - #315
Merged
Merged
Conversation
max-models
marked this pull request as draft
August 3, 2026 12:56
max-models
force-pushed
the
upload-profiling-figures
branch
from
August 3, 2026 14:49
153eaec to
6e34d3d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the profiling packaging/upload flow so that each run’s post-processed artifacts (figures/arrays written to <sim_dir>/results) are included in the packaged case folder and uploaded to the struphy-hub/profiling-data repository, with a cleaned-up per-run folder structure (<case>/results-runXX).
Changes:
- Add standalone CLI support to upload an already-packaged case directory to
profiling-data. - Restructure packaged output to be per-run (
results-runXX/) and write per-run metadata files (runXX.json) referenced fromcase_metadata.json. - Update the Poisson profiling example to write post-processed artifacts to
sim.env.path_out/resultsso packaging can pick them up.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| profiling/upload.py | Adds a CLI entrypoint to upload an already-packaged case folder to profiling-data using existing clone/push helpers. |
| profiling/profiling_job.py | Switches packaging bookkeeping from per-file to per-run, copies sim_<id>/results artifacts, and updates finalize messaging. |
| profiling/package_profiling_results.py | Introduces per-run naming helpers, per-run metadata writer, and logic to copy result artifacts from <sim_dir>/results. |
| profiling/examples/Poisson/cube_strong_scaling/params_poisson.py | Writes post-processed outputs into sim.env.path_out/results to align with the new packaging collector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
max-models
marked this pull request as ready for review
August 4, 2026 06:18
spossann
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uploads all figures found in
results_dir = os.path.join(sim.env.path_out, "results")to theprofiling-datarepository. These figures are then displayed on the individual run pages.Example: https://struphy-hub.github.io/profiling-data/run/?case=20260803T090820Z-b8a5ed8f-poisson_cube_strong_scaling&run=run03#gallery
Additionally, I cleaned up the filenames and folder structure in
profiling-data, now all the files for each run are categorized in a case/results-run02. See here.