Skip to content

Upload profiling figures - #315

Merged
max-models merged 15 commits into
develfrom
upload-profiling-figures
Aug 4, 2026
Merged

Upload profiling figures#315
max-models merged 15 commits into
develfrom
upload-profiling-figures

Conversation

@max-models

@max-models max-models commented Aug 3, 2026

Copy link
Copy Markdown
Member

This PR uploads all figures found in results_dir = os.path.join(sim.env.path_out, "results") to the profiling-data repository. These figures are then displayed on the individual run pages.

Example: https://struphy-hub.github.io/profiling-data/run/?case=20260803T090820Z-b8a5ed8f-poisson_cube_strong_scaling&run=run03#gallery

Additionally, I cleaned up the filenames and folder structure in profiling-data, now all the files for each run are categorized in a case/results-run02. See here.

@max-models
max-models marked this pull request as draft August 3, 2026 12:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the profiling packaging/upload flow so that each run’s post-processed artifacts (figures/arrays written to <sim_dir>/results) are included in the packaged case folder and uploaded to the struphy-hub/profiling-data repository, with a cleaned-up per-run folder structure (<case>/results-runXX).

Changes:

  • Add standalone CLI support to upload an already-packaged case directory to profiling-data.
  • Restructure packaged output to be per-run (results-runXX/) and write per-run metadata files (runXX.json) referenced from case_metadata.json.
  • Update the Poisson profiling example to write post-processed artifacts to sim.env.path_out/results so packaging can pick them up.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
profiling/upload.py Adds a CLI entrypoint to upload an already-packaged case folder to profiling-data using existing clone/push helpers.
profiling/profiling_job.py Switches packaging bookkeeping from per-file to per-run, copies sim_<id>/results artifacts, and updates finalize messaging.
profiling/package_profiling_results.py Introduces per-run naming helpers, per-run metadata writer, and logic to copy result artifacts from <sim_dir>/results.
profiling/examples/Poisson/cube_strong_scaling/params_poisson.py Writes post-processed outputs into sim.env.path_out/results to align with the new packaging collector.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread profiling/package_profiling_results.py Outdated
Comment thread profiling/package_profiling_results.py
Comment thread profiling/profiling_job.py Outdated
max-models and others added 2 commits August 4, 2026 07:57
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@max-models
max-models marked this pull request as ready for review August 4, 2026 06:18
@max-models
max-models requested a review from spossann August 4, 2026 06:18
@max-models
max-models merged commit d23781e into devel Aug 4, 2026
26 checks passed
@max-models
max-models deleted the upload-profiling-figures branch August 4, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants