Skip to content

Improved Trapezoidal Mapping for FGM - Update - #2845

Open
tkiymaz wants to merge 15 commits into
developfrom
lut_fast
Open

Improved Trapezoidal Mapping for FGM - Update#2845
tkiymaz wants to merge 15 commits into
developfrom
lut_fast

Conversation

@tkiymaz

@tkiymaz tkiymaz commented Jul 15, 2026

Copy link
Copy Markdown

Proposed Changes

The original trapezoidal map implementation needs excessive memory for large lookup tables (LUT) (e.g., 300+ MB for tables with ~80k points). This PR introduces a new memory-efficient trapezoidal map implementation (LUT_FAST) for Flamelet-Generated Manifold (FGM) lookup tables, based on LUT algorithm of Pedro Gomes. The new implementation reduces memory usage while maintaining query performance. A new unit test is created and all tests are passed.

Related Work

This code is an implementation of https://github.com/pcarruscag/LUT to SU2.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [ x] I am submitting my contribution to the develop branch.
  • [ x] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • [x ] I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted

Copy link
Copy Markdown
Contributor

just remove the old trapezoidal map and use the new one for everything. Just rename trapezoidalmapFAST trapezoidalmap.

@tkiymaz

tkiymaz commented Jul 28, 2026

Copy link
Copy Markdown
Author

I have verified the new implementation against the old one using the fgm unsteady testcase. It produces identical history and restart files. Map memory for the 7k-point FGM table drops from 18.2 MB to 1.3 MB.

@bigfooted

Copy link
Copy Markdown
Contributor

@tkiymaz can you fix the conflicts so the regression tests run again?

@bigfooted

Copy link
Copy Markdown
Contributor

Ok great, If you think it's ready just remove the WIP and pr:draft label

@tkiymaz tkiymaz changed the title [WIP] Improved Trapezoidal Mapping for FGM - Update Improved Trapezoidal Mapping for FGM - Update Aug 12, 2026
@tkiymaz tkiymaz removed the PR: draft label Aug 12, 2026
@tkiymaz

tkiymaz commented Aug 12, 2026

Copy link
Copy Markdown
Author

Ok great, If you think it's ready just remove the WIP and pr:draft label

I tested couple of times, I think it is ready. I changed the title and remove the pr:draft label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants