Skip to content

feat(build): remove boilerplate code with lombok#92

Open
mbocek wants to merge 1 commit into
subhra74:masterfrom
mbocek:master
Open

feat(build): remove boilerplate code with lombok#92
mbocek wants to merge 1 commit into
subhra74:masterfrom
mbocek:master

Conversation

@mbocek

@mbocek mbocek commented Feb 9, 2020

Copy link
Copy Markdown
Contributor

#85 Example of how to reduce boilerplate code.

@eitch

eitch commented Feb 10, 2020

Copy link
Copy Markdown

I know everyone loves removing boilerplate, but an IDE can easily manage the getters and setters and thus this is just unnecessary dependencies... =) and complicates building etc.

@mbocek

mbocek commented Feb 10, 2020

Copy link
Copy Markdown
Contributor Author

The build is straight forward. All major IDEs have support for Lombok (IntelliJ Idea, Eclipse...)
As usual, the decision is on the maintainer. For me, less code is better.

@aaabidunique

Copy link
Copy Markdown

@subhra74 Please consider merging this PR as it will be quite helpful later while code cleanup.

@andy-goryachev

Copy link
Copy Markdown

please do not add unnecessary dependencies.
removing boilerplate code is, in my opinion, not the most pressing issue in software development.

@uli-heller

Copy link
Copy Markdown

@andy-goryachev : I agree, removing boilerplate code is not the most pressing issue.
@eitch : I often see projects having IDE generated getters and setters and equals and hashCode. The issue comes up when someone adds a property later on and doesn't keep all of these in sync. I personally like the lombok approach much better. So I would vote to merge the PR

@aaabidunique

Copy link
Copy Markdown

Lombok doesn't only provide getter/setter but also provide other functionality like logger, builders etc thats why I asked to get it merged.
Anyways its up to the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants