ci: stop cancelling in-flight macOS native-image builds on main#1024
Open
nielspardon wants to merge 1 commit into
Open
ci: stop cancelling in-flight macOS native-image builds on main#1024nielspardon wants to merge 1 commit into
nielspardon wants to merge 1 commit into
Conversation
The macOS native-image workflow shared one concurrency group across all pushes to main with cancel-in-progress: true, so a newer merge cancelled the in-flight build (the ~20-25 min long pole). GitHub folds the resulting cancelled check-run into the commit's checks summary as a red X, so main appeared to fail intermittently whenever merges clustered. Drop the concurrency group so every push builds to completion and gets its own macOS native-image signal, matching the workflow's documented per-merge intent. Bursts of merges can now build in parallel on the shared GitHub-hosted macOS runner pool rather than collapsing to the head commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macOS native-image workflow shares one concurrency group across all pushes to
mainwithcancel-in-progress: true:Because the macOS build is the long pole (~20-25 min), any newer merge to
maincancels the in-flight build. When merges cluster (e.g. a dependabot batch, or two PRs landing close together) the earlier runs get cancelled. GitHub folds the resultingcancelledcheck-run into the commit's checks summary and renders it as a red ✗0 / 1— visually identical to a genuine failure — somainappears to fail intermittently.This also contradicts the workflow's own documented goal of a "per-merge signal": with cancellation, only the head of a burst actually gets built.
Fix
Drop the concurrency group entirely. Every push to
mainnow builds to completion and produces its own macOS native-image signal. No run is ever cancelled, so each commit shows a real ✓ (or a genuine ✗ only if the native build actually breaks).Note:
cancel-in-progress: falsewould not fully fix this — with a concurrency group, GitHub keeps only the newest pending run, so bursts of 3+ merges would still cancel the intermediate ones. Removing the group is what eliminates cancellations.Trade-off
When merges cluster, macOS builds can now run in parallel on the shared GitHub-hosted macOS runner pool rather than collapsing to just the head commit. For this public repo those runners are free; the cost is heavier pool usage during bursts. The weekly backstop and
workflow_dispatchtriggers are unchanged.🤖 Generated with AI