Conversation
[Problem] Cfg files don't support key-value maps and the requests library expects a dict with the headers. The current implementation blindly passes what was found under the headers key in config, which in the case of a cfg/ini config will be a string causing an exception to be raised. [Solution] Check if the value found under the headers key is a string and assume it's a json if so.
Author
|
@suchmememanyskill sorry for the direct ping, but this is a small change and I would love to have it in the next release of the Snapmaker u1 extended firmware 🤞🏻 |
Owner
|
Currently on holiday, cannot look now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Problem]
Cfg files don't support key-value maps and the requests library expects a dict with the headers. The current implementation blindly passes what was found under the headers key in config, which in the case of a cfg/ini config will be a string causing an exception to be raised.
[Solution]
Check if the value found under the headers key is a string and assume it's a json if so.