Conversation
…fraction profiling
Add QwenVLWorstCaseMixin as first base class in all three Qwen VL visual transformer classes so the worst-case activation reservation API is available. Also make model_infer/__init__.py imports of VisualModelRpcServer and VisualModelRpcClient lazy (inside function bodies) to break the circular import that arose: qwen2_visual -> worst_case_reserve -> model_infer/__init__ -> model_rpc -> qwen2_visual.
…ecedence, fallback warn)
… cap Codex finding: the square floor (isqrt then floor to a merge-unit multiple) built 180x180=32400 patches for the default caps, under the 32768-patch (8192 merged-token) cap, so the startup probe could under-reserve vs the largest valid request. Round the square side up so total patches >= the binding cap (an upper bound, never an undershoot).
…erved Codex finding: reset_peak_memory_stats ran after weights were on the GPU, so max_memory_reserved() returned weights+activation. The published SharedInt value and the [mem] log / fail-fast hint said 'activation memory' but included ViT weights (e.g. InternViT-6B made InternVL report 12.59 GB when the activation is ~1.8 GB). Capture the reserved baseline before the dummy forward and return peak-baseline. The physical hold is unchanged (still no empty_cache), so pool sizing is unaffected; only the diagnostic is now accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.