feat: make PKCE optional for confidential clients in OAuth server#2596
Open
gourabsingha1 wants to merge 1 commit into
Open
feat: make PKCE optional for confidential clients in OAuth server#2596gourabsingha1 wants to merge 1 commit into
gourabsingha1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes PKCE (Proof Key for Code Exchange) optional for confidential clients in the OAuth server, while keeping it mandatory for public clients (such as Single Page Apps or mobile apps) in accordance with OAuth 2.1 guidelines.
Currently, the OAuth server mandates PKCE for all authorization code flow requests regardless of client type. However, confidential clients (which possess secure client secrets and authenticate themselves securely at the token endpoint) do not strictly require PKCE for security.
Changes
validateRemainingAuthorizeParamsandvalidatePKCEParamsininternal/api/oauthserver/authorize.goto accept theclientobject (*models.OAuthServerClient).validatePKCEParamsto allow requests from confidential clients (client.IsPublic() == false) where bothcode_challengeandcode_challenge_methodare omitted.internal/api/oauthserver/authorize_test.goto verify:Fixes #2585