chore(cli): define error actionability taxonomy#5775
Conversation
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@44f3cd7f009af79bf620c49ac38a65c74426292ePreview package for commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 511b9e3b61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 786bba4590
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
786bba4 to
b26bfe6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b26bfe6b63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
b26bfe6 to
b8a178b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8a178ba4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
b8a178b to
8809e4c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8809e4c704
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
8809e4c to
d9f5099
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9f509914d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
d9f5099 to
bfe8271
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfe8271f0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
bfe8271 to
0aa23a6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0aa23a6145
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
0aa23a6 to
32045e5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32045e5fb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
32045e5 to
d3c25fe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3c25fe0e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
d3c25fe to
99b1f00
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99b1f00ac5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
99b1f00 to
6e3a70a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e3a70af06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
6e3a70a to
fec1bae
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fec1bae011
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
fec1bae to
003c29d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 003c29dd8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
003c29d to
4fc9f35
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fc9f35a67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
4fc9f35 to
0b91f42
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b91f42490
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
0b91f42 to
cbcb7e0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbcb7e01f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
cbcb7e0 to
8577e5c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8577e5c649
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
8577e5c to
afc01d5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afc01d54d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
afc01d5 to
4be05e0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be05e02aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
4be05e0 to
37efe38
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37efe38abf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
37efe38 to
650a763
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 650a763799
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
650a763 to
7097e17
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7097e17c48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
7097e17 to
6fa7002
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fa7002bfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
6fa7002 to
ae7c3f2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae7c3f2068
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
ae7c3f2 to
2dfad11
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dfad1158f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
2dfad11 to
7280086
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7280086789
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
7280086 to
44f3cd7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44f3cd7f00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (arg.startsWith("-o") && arg.length > 2) { | ||
| const value = arg.slice(2); |
There was a problem hiding this comment.
When a pre-handler failure includes a value-taking command flag whose value happens to look like an attached output shorthand, for example supabase functions deploy --import-map -ojson --bad, this scanner treats the import-map path as -o json even though the parser consumes it as the --import-map value. Fresh evidence beyond the earlier attached--o fix is that this new branch scans every argv token without the value-consuming skip logic used by legacy telemetry, so these root failure events record output_format=json instead of the resolved text/default format.
Useful? React with 👍 / 👎.
| yield* captureHandledPreHandlerFailureTelemetry( | ||
| outputFormatForRootTelemetry(args, outputFormat), | ||
| finishedAt - startedAt, | ||
| exit.cause, | ||
| ); |
There was a problem hiding this comment.
When an allowlisted tag is raised from inside an already-instrumented handler, for example functions serve loading a malformed project config via shared/functions/serve.ts, withLegacyCommandInstrumentation has already emitted cli_command_executed before rethrowing. This outer failure path then treats the same handler failure as pre-handler telemetry and emits a second command event for the same run, inflating failures for tags such as ProjectConfigParseError or port-allocation StackError.
Useful? React with 👍 / 👎.
| LegacyGenSigningKeyConfigParseError: invalidConfigTemplate, | ||
| LegacyGenSigningKeyReadError: permissionTemplate, | ||
| LegacyGenSigningKeyDecodeError: invalidConfigTemplate, | ||
| LegacyGenSigningKeyWriteError: permissionTemplate, |
There was a problem hiding this comment.
gen signing-key can raise LegacyGenSigningKeyGenerateError after config loading when key generation/JWK export fails or the exported key is missing required fields (signing-key.handler.ts). This taxonomy maps the neighboring config/read/decode/write signing-key tags but omits the generation tag, and no suffix fallback matches it, so those internal crypto/runtime failures are recorded as unknown instead of a stable internal/rerun-debug bucket.
Useful? React with 👍 / 👎.
| LegacyExperimentalRequiredError: provideFlagsTemplate, | ||
| LegacyDbDumpRequiresDataOnlyError: provideFlagsTemplate, | ||
| LegacyDbDumpMutuallyExclusiveFlagsError: provideFlagsTemplate, | ||
| LegacyDbDumpOpenFileError: provideFlagsTemplate, |
There was a problem hiding this comment.
LegacyDbDumpOpenFileError is raised from db dump --file when opening the destination path fails, so the user usually needs to fix the output path or filesystem permissions. Mapping it to provide_flags records these local file I/O failures as missing/invalid flag input, unlike the other local write failures in this taxonomy that use the permission bucket.
Useful? React with 👍 / 👎.
| LegacyStorageConfigError: invalidConfigTemplate, | ||
| LegacyStorageMissingApiKeyError: permissionTemplate, | ||
| LegacyStorageObjectNotFoundError: invalidInputTemplate, | ||
| LegacyStorageFileError: invalidInputTemplate, |
There was a problem hiding this comment.
LegacyStorageFileError wraps local read/create/mkdir failures during storage cp uploads and downloads, such as an unreadable source file or unwritable destination directory. Classifying it as invalid_input loses the local permission/path remediation and groups it with bad storage URLs or missing buckets instead of the permission bucket used for other filesystem failures.
Useful? React with 👍 / 👎.
1 participant
Defines the CLI error actionability taxonomy for KPI reporting and adds a sanitized classifier contract for future
cli_command_executedfailure metadata.This keeps the Q2 recovery and repeat definitions close to the telemetry catalog, while preserving the current behavior that command events only emit existing fields until the follow-up instrumentation issue wires classification into capture.