-
Notifications
You must be signed in to change notification settings - Fork 516
feat(cli): inject function slug into served fns #6345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raulb
wants to merge
7
commits into
develop
Choose a base branch
from
raulb/inject-function-slug-env-var
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+293
−15
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2989c69
feat(cli): inject function slug into served fns
raulb 954c972
refactor: address PR feedback
raulb c24a039
Merge branch 'develop' into raulb/inject-function-slug-env-var
raulb cbc9aec
refactor: undo
raulb 10eb8ec
fix: address PR feedback
raulb 55f2254
fix: address p2
raulb 4694df4
Merge branch 'develop' into raulb/inject-function-slug-env-var
raulb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the offline Docker test, this fixed sleep turns cold-worker startup into wall-clock polling; on slow CI it delays every retry and, if the worker remains unavailable, eventually throws without the runtime/container diagnostics needed to investigate the failure. Synchronize on an explicit worker or container readiness signal instead, retaining stderr/stdout diagnostics; the repository explicitly treats startup polling delays and arbitrary sleeps as blocking.
AGENTS.md reference: AGENTS.md:L318-L322
Useful? React with 👍 / 👎.