Use arrow as intermediate type representation#797
Draft
bnjjj wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
bnjjj
commented
Jun 2, 2026
Contributor
Author
There was a problem hiding this comment.
This is probably a bad merge conflict
bnjjj
commented
Jun 2, 2026
Contributor
Author
There was a problem hiding this comment.
Same here, probably merge conflict issue
bnjjj
commented
Jun 2, 2026
| Ok(()) | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
Contributor
Author
There was a problem hiding this comment.
merge conflict issue ?
bnjjj
commented
Jun 2, 2026
| /// Converts destination-facing Arrow CDC batches back to DuckLake row | ||
| /// events. | ||
| async fn stream_batches_to_events(&self, batches: Vec<StreamBatch>) -> EtlResult<Vec<Event>> { | ||
| let mut events = Vec::new(); |
Contributor
Author
There was a problem hiding this comment.
I think we can set a default capacity here
bnjjj
commented
Jun 2, 2026
Contributor
Author
There was a problem hiding this comment.
Why does it need to have pub structs and so one now ?
bnjjj
commented
Jun 2, 2026
Comment on lines
-162
to
-166
| /// Shutdown requested. | ||
| /// | ||
| /// No new WAL is accepted, but buffered or in-flight destination work is | ||
| /// still allowed to drain. | ||
| DrainingForShutdown, |
bnjjj
commented
Jun 2, 2026
| /// Cleanup is considered only after status updates, because those are natural | ||
| /// progress points where durable ETL progress may have advanced. The next | ||
| /// deadline is scheduled when the previous cleanup task finishes. | ||
| const SCHEMA_CLEANUP_INTERVAL: Duration = Duration::from_hours(1); |
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
bnjjj
commented
Jun 2, 2026
Comment on lines
+83
to
+100
| counter!(ETL_BYTES_PROCESSED_TOTAL, EVENT_TYPE_LABEL => "copy") | ||
| .increment(row_size_bytes); | ||
| counter!( | ||
| ETL_BYTES_PROCESSED_TOTAL, | ||
| PIPELINE_ID_LABEL => this.pipeline_id.to_string(), | ||
| EVENT_TYPE_LABEL => "copy" | ||
| ) | ||
| .increment(row_size_bytes); | ||
|
|
||
| histogram!(ETL_ROW_SIZE_BYTES, EVENT_TYPE_LABEL => "copy") | ||
| .record(row_size_bytes as f64); | ||
| histogram!( | ||
| ETL_ROW_SIZE_BYTES, | ||
| PIPELINE_ID_LABEL => this.pipeline_id.to_string(), | ||
| EVENT_TYPE_LABEL => "copy" | ||
| ) | ||
| .record(row_size_bytes as f64); |
Contributor
Author
There was a problem hiding this comment.
I don't think this is required because #652
bnjjj
commented
Jun 2, 2026
Comment on lines
-200
to
+209
| replicated_table_schema: ReplicatedTableSchema, | ||
| table_schema: Arc<TableSchema>, |
Contributor
Author
There was a problem hiding this comment.
I'm suspicious about this.
bnjjj
commented
Jun 2, 2026
| histogram!(ETL_PARALLEL_TABLE_COPY_TIME_IMBALANCE).record(time_lif); | ||
| histogram!( | ||
| ETL_PARALLEL_TABLE_COPY_TIME_IMBALANCE, | ||
| PIPELINE_ID_LABEL => pipeline_id.to_string(), |
Contributor
Author
There was a problem hiding this comment.
Should not be required here because we add it before as a global label when starting replicator
bnjjj
commented
Jun 2, 2026
| histogram!(ETL_PARALLEL_TABLE_COPY_ROWS_IMBALANCE).record(rows_lif); | ||
| histogram!( | ||
| ETL_PARALLEL_TABLE_COPY_ROWS_IMBALANCE, | ||
| PIPELINE_ID_LABEL => pipeline_id.to_string(), |
Contributor
Author
There was a problem hiding this comment.
Should not be required here because we add it before as a global label when starting replicator
bnjjj
commented
Jun 2, 2026
|
|
||
| histogram!( | ||
| ETL_TABLE_COPY_ROWS, | ||
| PIPELINE_ID_LABEL => pipeline_id.to_string(), |
bnjjj
commented
Jun 2, 2026
| histogram!( | ||
| ETL_TABLE_COPY_ROWS, | ||
| PIPELINE_ID_LABEL => pipeline_id.to_string(), | ||
| DESTINATION_LABEL => D::name(), |
Contributor
Author
There was a problem hiding this comment.
Maybe we should do the same for destination if it's not already done
bnjjj
commented
Jun 2, 2026
|
|
||
| // Serialized via nextest test-group "shared-pg" (shares the source PG cluster). | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| #[ignore = "modifies cluster-wide PG settings; run independently with: cargo test -- --ignored \ |
bnjjj
commented
Jun 2, 2026
|
|
||
| // Serialized via nextest test-group "shared-pg" (shares the source PG cluster). | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| #[ignore = "modifies cluster-wide PG settings; run independently with: cargo test -- --ignored \ |
bnjjj
commented
Jun 2, 2026
| /// 4. Insert 3 new rows (ids 100-102) for users only | ||
| /// 5. Verify: users has 10 total rows (table_rows + events), orders unchanged | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| async fn table_sync_drops_destination_table_after_state_reset() { |
bnjjj
commented
Jun 2, 2026
bnjjj
left a comment
bnjjj
left a comment
Contributor
Author
There was a problem hiding this comment.
Do not remove tests if this is not for removed code
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal is to get rid of
TableRowandCellto only use arrow types and benefit from arrow allocations and compliant destinations with arrow