ref(api): Rework how replicator resources are done#883
Merged
Conversation
iambriccardo
commented
Jul 8, 2026
bnjjj
approved these changes
Jul 8, 2026
7930387 to
75e863c
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
k8s.replicator_resourcesuses the clearerDefaultReplicatorResourcesConfigtype and requires only baseline replicator CPU/memory requests.replicator_resourcesfully optional withReplicatorResourcesConfig: pipelines can override CPU/memory requests and/or explicit CPU/memory limits, while omitted limits are derived from the final request values using the static ETL API multipliers.ReplicatorStatefulSetResourcesConfig, using API defaults plus optional pipeline overrides for the replicator container and static constants for the vector container; final requests are clamped to the API's minimum emitted CPU/memory values and limits are never below their paired requests.skip_serializing_if = "Option::is_none"usage across related ETL API config/response types.Validation
cargo x fmtcargo check -p etl-api --all-targets --all-featurescargo nextest run -p etl-api --all-features -E 'test(replicator_stateful_set_resources) | test(pipeline_replicator_resources_are_persisted_and_used_on_start) | test(updating_a_running_pipeline_reapplies_replicator_resources) | test(updating_a_stopped_pipeline_only_persists_replicator_resources) | test(invalid_replicator_resources_are_rejected) | test(stored_pipeline_config_serialization) | test(stored_pipeline_config_deserializes_without_replicator_resources)'cargo nextest run -p etl-api --all-features -E 'test(test_create_ducklake_replicator_stateful_set_json) | test(test_create_bq_replicator_stateful_set_json) | test(test_create_iceberg_replicator_stateful_set_json) | test(test_create_init_containers)'cargo clippy -p etl-api --all-targets --all-features -- -D warnings