Repository navigation
Conversation
…lpers in cli/lib Moves the migration-history reader and sorter (build-database-005, investigate-database-001), the psql runner (investigate-database-001) and readStackLifecycle (build-database-006) into evals/cli/lib, and points the evals at them. Pass/fail behaviour is unchanged; 005's history query now runs psql with -X like the other callers.
…pers Replace 002's inline migration-history query and parser with readMigrationHistory and sortMigrationsByHistory, and drop its local describeMissingVersions and stack-lifecycle reader in favour of the lib versions. Its lifecycle test cases move to lib/cli-invocations.test.ts.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coly010
marked this pull request as ready for review
October 23, 2026 13:27
…eval-helpers # Conflicts: # apps/web/src/data/cli-eval-results.json
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four CLI evals had their own copies of the same migration-history query, psql runner and stack start/stop reader. This moves the shared pieces into
evals/cli/liband points the evals at them. Eval behaviour isn't meant to change.What moved
lib/psql.ts(new):queryDatabase(ctx, stack, sql, parse)runs one read-only query withpsql -XtAcand hands stdout to a parser. Moved from investigate-database-001.lib/migrations.ts:readMigrationHistoryqueriessupabase_migrations.schema_migrationsfor a set of versions and returns each one's statements.sortMigrationsByHistorysplits migrations into recorded, missing and mismatched using an eval-supplied match function.describeMissingVersionsandcheckMigrationsRecordedare the shared report and check wrappers.lib/cli-invocations.ts:readStackLifecyclereturns the agent's last stack start/stop command and whether it left the stack stopped. Moved from build-database-006; 002 had a text-identical copy.Evals touched
The
run-evals-changedlabel re-runs all four. Pass rates should match their last run on main.Worth a look
psql -XtAc. 005 previously used-tAc, and 002 used-X -A -t -q -v ON_ERROR_STOP=1 -c. For a single read-only select the output is the same;-Xjust skips any.psqlrc.psqlCommand, because its callers pipe scripts or pass extra flags.compareTextone-liner that 001, 005 and 002 each define.🤖 Generated with Claude Code