Skip to content

fix: retrieve the zero-argument function overload when args is empty #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsusul wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −7
Open

fix: retrieve the zero-argument function overload when args is empty #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/lib/sql/functions.sql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,9 @@ with functions as (
${
props.args === undefined
? ''
: props.args.length > 0
? `p.proargtypes::text = ${
props.args.length
? `(
: `p.proargtypes::text = ${
props.args.length > 0
? `(
SELECT STRING_AGG(type_oid::text, ' ') FROM (
SELECT (
split_args.arr[
Expand All @@ -60,9 +59,8 @@ with functions as (
) AS split_args
) args
)`
: "''"
} AND`
: ''
: "''"
} AND`
}
p.prokind = 'f'
)
Expand Down
16 changes: 16 additions & 0 deletions test/lib/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,3 +531,19 @@ test('retrieve function by args filter - function with no arguments', async () =
})
expect(res.error).toBeNull()
})

test('retrieve function by args filter - zero-argument overload among polymorphic functions', async () => {
const res = await pgMeta.functions.retrieve({
schema: 'public',
name: 'polymorphic_function_with_no_params_or_unnamed',
args: [],
})
expect(res.error).toBeNull()
expect(res.data).toMatchObject({
name: 'polymorphic_function_with_no_params_or_unnamed',
schema: 'public',
argument_types: '',
args: [],
return_type: 'integer',
})
})