fix: clean up query error listeners - #1120
Open
hsusul wants to merge 1 commit into
Open
Conversation
Signed-off-by: Henry Su <henrysu4707@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1118
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Every query adds a one-shot error listener to the shared PostgreSQL pool. Successful queries and query-level rejections do not remove it, so completed queries accumulate stale listeners and eventually trigger MaxListenersExceededWarning.
What is the new behavior?
The query wrapper now settles through shared resolve and reject paths that clear any delayed connection-error timer and remove the exact temporary pool listener. Connection-level pool errors retain their existing next-tick arbitration and still propagate to the caller.
Tests
Added focused mocked-pool coverage for:
Local validation:
Docker-backed integration tests were unavailable because the local Docker daemon is not running.
Additional context
#911 introduced connection-level error propagation but does not clean up listeners after ordinary completion. Open #782 is a broader client abstraction refactor and does not report this listener leak.