fix: keep the whole role config value after the first equals sign - #1130
Open
Kjubikstronk wants to merge 1 commit into
Open
fix: keep the whole role config value after the first equals sign#1130Kjubikstronk wants to merge 1 commit into
Kjubikstronk wants to merge 1 commit into
Conversation
Kjubikstronk
requested review from
a team,
avallete and
soedirgo
as code owners
August 31, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1117.
changeRoleConfig2Objectdestructurescur.split('=')into two variables, so everything after the second equals sign is discarded. Arolconfigentry likeapplication_name=api=workercomes back asapplication_name: api.Postgres only treats the first equals sign as the separator between the setting name and its value. The rest belongs to the GUC value and should round-trip unchanged.
Fixed by keeping the remainder of the split and rejoining it. An entry with no equals sign still gives
undefined, exactly as before.Five unit tests in
test/role-config.test.ts. They import the function directly and need no database, so they run without the Docker setup. Two of them fail without the change and the other three pass either way, which pins the existing behaviour as well as the fix.tsc -p tsconfig.json --noEmitandprettier --checkare both clean.