AMI: Pin down uid/gid values when creating users/groups - #2412
Open
mmlb wants to merge 3 commits into
Open
Conversation
Nothing uses it and its just a drag on the repo, for understanding it and grepping.
Ran into issue with different gids between AMIs that caused suspend/wake to fail due to permission errors. The previous goss tests were only checking for user/group existence which is a very light weight test, uid/gid are the only thing that matter not the user/group name. We now explicitly pin the uid and gid so that we avoid this issue in the future, goss verifies at ami build time.
This adds ansible-lint with a custom lint rule that ensures we explicitly set uid and gid when using the user and group modules. This way we don't end up with unknown/different values between AMI builds.
PostgreSQL Extension Dependency Analysis: PR #2412
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2412
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
sugatmahanti
approved these changes
Sep 1, 2026
Contributor
|
Note that this enforces "bad" UIDs on these users. UIDs over 1000 are for human users, not for system services. System services should have an UID below 1000 (well, on debian, 500 for RH systems as far as I remember). |
pcnc
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
We create users/groups willy nilly without a worry about uid/gids assigned to them.
What is the new behavior?
We no longer do that. Any user/group created in ansible needs to provide the relevant uid/gid, this is checked by a custom ansible-lint linter. We also check the uid/gid using supascan/goss at ami build time to catch any unexpected change.
Additional context
When I dropped the nginx user/group the other uid/gids changed and caused an issue with resume from suspend due to file perms.Nothing uses it and its just a drag on the repo, for understanding it
and grepping.