fix: leak in iceberg upload part#1123
Open
ferhatelmas wants to merge 2 commits into
Open
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a stream leak in the Iceberg-specific S3 UploadPart route by ensuring the PassThrough stream that the request body is piped into is actually the stream consumed by the upload implementation.
Changes:
- Always create and pipe
ctx.req.rawinto aPassThroughfor the IcebergUploadParthandler. - Use the
PassThroughas theBodystream for non-streaming-signature uploads (previously,ctx.req.rawwas used while thePassThroughremained unconsumed).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 26506685018Coverage increased (+0.02%) to 75.19%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
fenos
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Upload part is using passthrough but not consuming it.
What is the new behavior?
Passthrough is passed correctly.