chore: mark concurrent PKCE flows as implemented in the compliance matrix - #1787
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughChangesPKCE compliance declarations
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized compliance-matrix update records an already implemented PKCE capability and moves its related symbols to the correct entry; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
The capability-ID sync in #1786 added
auth.sign_in.concurrent_pkce_flowstosdk-compliance.yamlwith the defaultnot_implementedstatus. The capability is already implemented, so this marks itimplementedand gives it the symbols that describe it.Why it is already implemented
The canonical capability asks for each PKCE code verifier to live in its own bounded, per-flow slot keyed by a generated flow id, with the code exchange accepting an optional flow id to select the right verifier. That is what
PKCEVerifierStoredoes, landed in #1662 and refactored in #1744:AuthConstants.pkceMaxConcurrentFlows(5) evicts the oldest.AuthClient.exchangeCodeForSessiontakes an optionalflowIdand validates it before building a storage key.AuthClient.appendPkceFlowIdToRedirectsandAuthClientOptions.appendPkceFlowIdToRedirectsput the id on the callback URL, andgetOAuthSignInUrl/getLinkIdentityUrlreturn it asOAuthResponse.flowId.Changes
AuthClient.appendPkceFlowIdToRedirects,AuthClientOptions.appendPkceFlowIdToRedirectsandOAuthResponse.flowIdmove fromauth.sign_in.exchange_code_for_sessionto the new capability, which is where they belong now that it exists.exchange_code_for_sessionkeepsAuthClient.exchangeCodeForSession.No note is added, since the implementation matches expected parity.
Verification
The supabase/sdk compliance tooling was run locally against this branch:
Summary by CodeRabbit