Isolate onboarding tracking-callback failures from UI state - #25
Conversation
A synchronous throw from onboardingActionProperties (invalid action or preferences state) previously propagated through the caller's own try/catch: in RepositoryEntry it blocked a valid repository submission from navigating, and in CopyCommand it made a successful clipboard copy report a false error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScTMQJpjhH7qyf5tP2KTaj
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🤖 review-bot (run 2026-09-03 · HEAD Generated by Claude Code |
|
🤖 review-bot (run 2026-09-03 · HEAD Generated by Claude Code |
✅ Review-bot convergedrun 2026-09-03 · HEAD Bot pass on this HEAD: cubic completed — "No issues found" across the 2 changed files. coderabbit hit its OSS review-limit rate cap and declined ("next included review available in 47 minutes") — not a real review, nothing to triage from it. greptile, gemini-code-assist, and copilot never published a check-run or review on this HEAD after the grace window; since cubic had already picked the PR up, that's treated as "not enabled here," not "missed," so no nudge was sent. No bot posted a single line-anchored finding. Nothing to triage — no triage table, no commits, no replies. Loop totals: 1 round, 0 findings. Generated by Claude Code |
Follow-up to #24, which merged (09:24:55 UTC) before CodeRabbit's review landed on the rebased HEAD (09:28:07 UTC) — the automated review-bot triage below was posted to the now-closed #24 but never got a chance to land its fixes there, so this PR carries them against
maininstead.Both findings were verified against the current code and are real:
src/lib/onboarding/RepositoryEntry.svelte:await onopen?.()can throw synchronously —reportAction→onboardingActionPropertiesthrows on an unrecognized action or invalid preferences state — beforelocation.assign(path)runs, so a tracking-layer failure blocks a valid repository submission entirely. Wrap the tracking call in its owntry/catchso navigation always proceeds.src/lib/onboarding/CopyCommand.svelte:oncopied?.()ran inside thewriteTexttry, so the same synchronous throw from the tracking layer would resetisCopiedand show a false "Couldn't copy" error after a successful clipboard write. Isolate the tracking callback so it can't affect copy-success feedback.Both fixes apply CodeRabbit's proposed patch essentially as-is.
Validation:
bun test: 74 passed (same 2 pre-existing, unrelated failures as onmain: a sandboxedbun x/preparescript failure and a missing optional@supabase/supabase-jsintegration-test dependency).🤖 Generated with Claude Code
https://claude.ai/code/session_01ScTMQJpjhH7qyf5tP2KTaj
Generated by Claude Code
Summary by cubic
Isolates onboarding tracking-callback failures so they can no longer affect navigation or copy-success feedback.
Written for commit dde4895. Summary will update on new commits.