Skip to content

Isolate onboarding tracking-callback failures from UI state - #25

Merged
Acksell merged 1 commit into
mainfrom
claude/eager-goldberg-7m0cez
Sep 3, 2026
Merged

Acksell merged 1 commit into
mainfrom
claude/eager-goldberg-7m0cez

Conversation

@Acksell

@Acksell Acksell commented Sep 3, 2026

Copy link
Copy Markdown
Member

Follow-up to #24, which merged (09:24:55 UTC) before CodeRabbit's review landed on the rebased HEAD (09:28:07 UTC) — the automated review-bot triage below was posted to the now-closed #24 but never got a chance to land its fixes there, so this PR carries them against main instead.

Both findings were verified against the current code and are real:

  • src/lib/onboarding/RepositoryEntry.svelte: await onopen?.() can throw synchronously — reportActiononboardingActionProperties throws on an unrecognized action or invalid preferences state — before location.assign(path) runs, so a tracking-layer failure blocks a valid repository submission entirely. Wrap the tracking call in its own try/catch so navigation always proceeds.
  • src/lib/onboarding/CopyCommand.svelte: oncopied?.() ran inside the writeText try, so the same synchronous throw from the tracking layer would reset isCopied and show a false "Couldn't copy" error after a successful clipboard write. Isolate the tracking callback so it can't affect copy-success feedback.

Both fixes apply CodeRabbit's proposed patch essentially as-is.

Validation:

  • bun test: 74 passed (same 2 pre-existing, unrelated failures as on main: a sandboxed bun x/prepare script failure and a missing optional @supabase/supabase-js integration-test dependency).

🤖 Generated with Claude Code

https://claude.ai/code/session_01ScTMQJpjhH7qyf5tP2KTaj


Generated by Claude Code


Summary by cubic

Isolates onboarding tracking-callback failures so they can no longer affect navigation or copy-success feedback.

  • Repository submission now proceeds even if the tracking callback throws.
  • A successful clipboard copy no longer shows an error if the tracking callback fails.

Written for commit dde4895. Summary will update on new commits.

Review in cubic

A synchronous throw from onboardingActionProperties (invalid action or
preferences state) previously propagated through the caller's own
try/catch: in RepositoryEntry it blocked a valid repository submission
from navigating, and in CopyCommand it made a successful clipboard copy
report a false error.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScTMQJpjhH7qyf5tP2KTaj
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 87ff1cd5-ef37-4f73-8b8c-f5a84d4b851f

📥 Commits

Reviewing files that changed from the base of the PR and between 85e4e8e and dde4895.

📒 Files selected for processing (2)
  • src/lib/onboarding/CopyCommand.svelte
  • src/lib/onboarding/RepositoryEntry.svelte

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Acksell commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

🤖 review-bot (run 2026-09-03 · HEAD dde4895) — ⏳ waiting on bot reviews (up to 25m)…


Generated by Claude Code

Acksell commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

🤖 review-bot (run 2026-09-03 · HEAD dde4895)⚠️ can't post commit statuses in this environment (no Statuses-API tool available) — merge-box signal disabled this run; activity stream is the source of truth.


Generated by Claude Code

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Acksell commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

✅ Review-bot converged

run 2026-09-03 · HEAD dde4895 · status → success (no commit-status tool available this run — see note above)

Bot pass on this HEAD: cubic completed — "No issues found" across the 2 changed files. coderabbit hit its OSS review-limit rate cap and declined ("next included review available in 47 minutes") — not a real review, nothing to triage from it. greptile, gemini-code-assist, and copilot never published a check-run or review on this HEAD after the grace window; since cubic had already picked the PR up, that's treated as "not enabled here," not "missed," so no nudge was sent.

No bot posted a single line-anchored finding. Nothing to triage — no triage table, no commits, no replies.

Loop totals: 1 round, 0 findings.


Generated by Claude Code

@Acksell
Acksell merged commit bffd1e9 into main Sep 3, 2026
3 checks passed
@Acksell
Acksell deleted the claude/eager-goldberg-7m0cez branch September 3, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants