Skip to content

api: remove VectorRequest #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
Oct 14, 2026
Merged

api: remove VectorRequest #7474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions api/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,3 @@ type VacateResponse struct {
type VacuumResponse struct {
ObjectIDs []uuid.UUID `super:"object_ids"`
}

type VectorRequest struct {
ObjectIDs []uuid.UUID `super:"object_ids"`
}
20 changes: 0 additions & 20 deletions api/client/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,26 +399,6 @@ func (c *Connection) Vacuum(ctx context.Context, tableName, revision string, dry
return res, err
}

func (c *Connection) AddVectors(ctx context.Context, tableName, revision string, objectIDs []uuid.UUID, message api.CommitMessage) (api.CommitResponse, error) {
return c.doVector(ctx, tableName, revision, objectIDs, message, http.MethodPost)
}

func (c *Connection) DeleteVectors(ctx context.Context, tableName, revision string, objectIDs []uuid.UUID, message api.CommitMessage) (api.CommitResponse, error) {
return c.doVector(ctx, tableName, revision, objectIDs, message, http.MethodDelete)
}

// XXX
func (c *Connection) doVector(ctx context.Context, tableName, revision string, objectIDs []uuid.UUID, message api.CommitMessage, method string) (api.CommitResponse, error) {
path := urlPath("tableName", tableName, "revision", revision, "vector")
req := c.NewRequest(ctx, method, path, api.VectorRequest{ObjectIDs: objectIDs})
if err := encodeCommitMessage(req, message); err != nil {
return api.CommitResponse{}, err
}
var res api.CommitResponse
err := c.doAndUnmarshal(req, &res)
return res, err
}

func (c *Connection) SubscribeEvents(ctx context.Context) (*EventsClient, error) {
req := c.NewRequest(ctx, http.MethodGet, "/events", nil)
req.Header.Set("Accept", api.MediaTypeSUP)
Expand Down
Loading