Repository navigation
vector/vbuild: fix DynamicBuilder bug on same-type dynamic - #7477
Merged
Merged
Conversation
A vector.Dynamic containing multiple vectors with the same type can reorder their values because the vectors are written to a single vbuild.Builder. Fix this by calling MergeSameTypesInDynamic. The test added in bsup/ztests/dynamic-same-type.yaml is unfortunately oblique because ztests don't offer a way to create a vector with a prescribed structure.
nwt
force-pushed
the
fix-NewDynamicBuilder-bug
branch
from
October 14, 2026 18:32
2e8797e to
c17ecec
Compare
Collaborator
Author
I think it's O(n * number of types in dynamic with same-type vectors). Looks like we can get that down to O(n) if we need to though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A vector.Dynamic containing multiple vectors with the same type can reorder their values because the vectors are written to a single vbuild.Builder. Fix this by calling MergeSameTypesInDynamic.
The test added in bsup/ztests/dynamic-same-type.yaml is unfortunately oblique because ztests don't offer a way to create a vector with a prescribed structure.