fix(web): Add awaiting_events to incident poller active states (fixes #398) - #421
Open
stroland02 wants to merge 1 commit into
Open
fix(web): Add awaiting_events to incident poller active states (fixes #398)#421stroland02 wants to merge 1 commit into
stroland02 wants to merge 1 commit into
Conversation
![superlog-app[bot]](https://avatars.githubusercontent.com/in/3485414?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the incident detail page would stop polling for updates while an agent run was in the \�waiting_events\ state. Because the web poller's canonical active-state mirror omitted \�waiting_events, the page would not automatically observe subsequent PR-event-driven resume, status, or transcript updates without a manual refresh. Adding \�waiting_events\ to the \ACTIVE_AGENT_RUN_STATES\ set ensures that polling continues as expected. A regression test has also been added. Fixes #398.
Summary by cubic
Keep polling on the incident page while an agent run is in the awaiting_events state, so PR comment/merge/close updates appear without a refresh. Adds awaiting_events to ACTIVE_AGENT_RUN_STATES and a regression test.
Written for commit 610bbdc. Summary will update on new commits.