Skip to content

fix(web): poll agent runs awaiting PR events - #437

Open
AnxForever wants to merge 1 commit into
superloglabs:mainfrom
AnxForever:fix/awaiting-events-polling
Open

fix(web): poll agent runs awaiting PR events#437
AnxForever wants to merge 1 commit into
superloglabs:mainfrom
AnxForever:fix/awaiting-events-polling

Conversation

@AnxForever

@AnxForever AnxForever commented Jul 30, 2026

Copy link
Copy Markdown

What & why

Keep the incident detail query polling while an agent run is in awaiting_events. PR comments, merges, and closes can resume this durable state, so stopping the poll left status and transcript updates stale until a manual refresh.

Fixes #398

How to test

  • pnpm --filter @superlog/web test
  • pnpm typecheck
  • pnpm exec biome check apps/web/src/incidents/agent-run-polling.ts apps/web/src/incidents/agent-run-polling.test.ts

AI assistance

  • None
  • Used AI for: reproducing the polling-state mismatch, drafting the focused fix, and adding the regression test

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would change existing behavior)
  • Documentation
  • Tests only
  • Refactor / cleanup

Checklist

  • pnpm typecheck passes
  • pnpm lint passes (current main has unrelated existing Biome diagnostics; the changed files pass targeted Biome checks)
  • pnpm format has been run on changed files
  • Added or updated tests where it makes sense
  • Branch is up to date with main
  • PR title follows the area-prefix style for the area being changed
  • Read CONTRIBUTING.md

Summary by cubic

Keep incident detail polling active while an agent run is in awaiting_events. This lets PR comments, merges, or closes resume the run and update status/transcript without a manual refresh, with a regression test added to cover the state.

Written for commit 889816f. Summary will update on new commits.

Review in cubic

Keep incident detail queries active while durable agent runs wait for
external PR events, and cover the resumable state with a regression test.

Fixes superloglabs#398

@superlog-app superlog-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observability review

All clear — no observability concerns found.

All signal, no noise. Ship it!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The web poller omits a worker-active state that can resume from external events

1 participant