fix(web): poll agent runs awaiting PR events - #437
Open
AnxForever wants to merge 1 commit into
Open
Conversation
Keep incident detail queries active while durable agent runs wait for external PR events, and cover the resumable state with a regression test. Fixes superloglabs#398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Keep the incident detail query polling while an agent run is in
awaiting_events. PR comments, merges, and closes can resume this durable state, so stopping the poll left status and transcript updates stale until a manual refresh.Fixes #398
How to test
pnpm --filter @superlog/web testpnpm typecheckpnpm exec biome check apps/web/src/incidents/agent-run-polling.ts apps/web/src/incidents/agent-run-polling.test.tsAI assistance
Type of change
Checklist
pnpm typecheckpassespnpm lintpasses (currentmainhas unrelated existing Biome diagnostics; the changed files pass targeted Biome checks)pnpm formathas been run on changed filesmainSummary by cubic
Keep incident detail polling active while an agent run is in
awaiting_events. This lets PR comments, merges, or closes resume the run and update status/transcript without a manual refresh, with a regression test added to cover the state.Written for commit 889816f. Summary will update on new commits.