Repository navigation
fix(mcp): keep implicit recall within readable scope - #1485
Closed
abhinav7x94 wants to merge 2 commits into
Closed
abhinav7x94 wants to merge 2 commits into
abhinav7x94 wants to merge 2 commits into
Conversation
Member
|
🤖 AI-assisted triage, reviewed by @MaheshtheDev. Thanks! Replaced by the v5 migration (#1783): MCP now uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search_memorycalls unscoped instead of forcingsm_project_defaultcontainerTag: nullWhy
A scoped OAuth connection could receive a misleading 403 because MCP turned "no usable selection" into an explicit request for
sm_project_default. Durable active state could also outlive or cross OAuth client grants and cause the same failure.This restores the behavior fixed by #1357 and later regressed by #1394.
Scope resolution
containerTag: nullThe visibility preflight uses the current bearer. If it fails, the tool returns an error without searching.
Testing
cd apps/mcp && bun run test:unit- 28/28 passed, including the production widget buildcd apps/mcp && bun run check-types- passedbunx biome check ...- passedgit diff --check- passedTest Coverage
Coverage gate: PASS (19/22 paths, 86%). Repository test files: 46 -> 48 (+2).
Pre-Landing Review
Independent testing, maintainability, API-contract, security, performance, and adversarial reviews completed. Contract/documentation drift and cross-client stale-active behavior were found and fixed. The final adversarial review reported no fixable security or correctness findings.
The inherited-active path intentionally adds one space-visibility request so a generic 403 is never retried as a broader search.
Design Review
No frontend files changed; visual review was not applicable.
Scope Drift
CLEAN - all nine changed files directly implement, test, or document this regression fix.
Documentation
apps/mcp/README.md: documents search-specific scope resolution and nullable outputapps/docs/supermemory-mcp/mcp.mdx: updates the tool reference and profile behaviorapps/docs/supermemory-mcp/setup.mdx: clarifies active-space and OAuth-scope fallback behavior