fix(tools): keep the forget-memory timeout when a caller passes a signal

[Agnik47]

Fixes #1549.

The problem

packages/tools/src/shared/forget-memory.ts combined the caller's signal and the 30s abort with ??, which makes them mutually exclusive:

signal: options?.signal ?? AbortSignal.timeout(FETCH_TIMEOUT_MS),

Pass a cancellation signal and the request becomes unbounded again — exactly the condition #1451 set out to remove. A caller who wants both cancellation and a timeout had no way to express it.

Latent rather than live today: neither production call site (ai-sdk.ts, openai/tools.ts) passes options. It becomes a real hang the first time someone wires up cancellation.

The fix

Compose the two signals instead of choosing between them:

signal: options?.signal
    ? AbortSignal.any([options.signal, AbortSignal.timeout(FETCH_TIMEOUT_MS)])
    : AbortSignal.timeout(FETCH_TIMEOUT_MS),

AbortSignal.any is available in Node 20.3+, Bun and workerd. Root package.json declares "node": ">=20", so in theory 20.0–20.2 are below the floor for this API; every maintained 20.x release is well past 20.3. Happy to guard it if you'd rather not rely on that.

Tests

The existing case — "uses a caller-provided signal instead of creating a timeout" — asserted the buggy behaviour (expect(init.signal).toBe(controller.signal)), so it could not survive the fix. It is replaced by two tests that pin the composed semantics:

• cancels through a caller-provided signal — the request signal is a composite rather than the caller's own, and aborting the caller still aborts the request.
• keeps the timeout when a caller-provided signal is present — AbortSignal.timeout is still called with 30_000, and firing only the timeout leg aborts the request.

Both new tests fail against the previous implementation (verified by reverting the source and keeping the tests):

× memoryForget > cancels through a caller-provided signal
  → expected AbortSignal { aborted: false } not to be AbortSignal { aborted: false }
× memoryForget > keeps the timeout when a caller-provided signal is present
  → expected "timeout" to be called with arguments: [ 30000 ]

Verification

• vitest run src/tool-operations.test.ts — 15/15 pass (was 14).
• Full packages/tools suite — 91 passed / 30 skipped. The two failing files (src/tools.test.ts, test/claude-memory.test.ts) fail identically on a clean origin/main checkout; they are the pre-existing collection errors tracked in @supermemory/tools fails check-types: 31 errors in test/, including an import of a file that no longer exists #1545, untouched by this change.
• biome check clean on both files; tsc --noEmit reports nothing on either file.

Unrelated, but noticed nearby

apps/mcp/src/server/client/index.ts:339 (getDocuments) has the identical options?.signal ?? AbortSignal.timeout(...) shape. Out of scope here — say the word and I'll open a separate issue or PR for it.

[phant0um]

I checked this PR and #1675, which fix the same bug (#1549). The test in this PR is the one that proves the bug.

I merged each PR onto main (cfa6c7c) locally and ran npx vitest run src/tool-operations.test.ts in packages/tools:

• This PR: 29 of 29 pass.
• The tests from this PR against the main version of forget-memory.ts: both new tests fail, for the right reason (expected "timeout" to be called with arguments: [ 30000 ]).

One gap: apps/mcp/src/server/client/index.ts uses the same options?.signal ?? AbortSignal.timeout(...) pattern in SupermemoryClient. #1675 fixes that file too. It is worth adding that hunk here.

[Agnik47]

Thanks for checking both, @phant0um — good catch on the MCP client.

Added in 014e1e9: SupermemoryClient.getDocuments now composes the caller signal with the 30s timeout via AbortSignal.any, same as forgetMemoryRequest.

It comes with its own regression test, apps/mcp/src/server/client/index.test.ts (2 cases: caller abort still cancels, and the timeout leg still fires when a caller signal is present). The timeout case fails against the main version of the client (expected "timeout" to be called with arguments: [ 30000 ]) and passes with the fix. tsc --noEmit for apps/mcp and tool-operations.test.ts in packages/tools are both green.

[MaheshtheDev]

🤖 AI-assisted triage, reviewed by @MaheshtheDev.

Thanks for this! The tools half no longer applies: forget-memory.ts was removed in the v5 migration (#1773/#1783). In the MCP server, no caller passes a signal to getGraphDocuments today, so the timeout already always applies. Closing.