Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/tools/src/claude-memory.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,29 @@ describe("ClaudeMemoryTool str_replace replacement literalness", () => {
expect(stored).toContain(`price is ${dollarSequence} today`)
})
})

describe("ClaudeMemoryTool path traversal", () => {
let tool: ClaudeMemoryTool

beforeEach(() => {
documentsListMock.mockReset()
documentsGetMock.mockReset()
addMock.mockReset()
mockDocument(FILE_CONTENT)
tool = new ClaudeMemoryTool("test-api-key")
})

it.each(["/memories/..", "/memories/foo/..", "/memories/../secrets.txt"])(
"rejects parent-directory path %s",
async (path) => {
const result = await tool.handleCommand({
command: "view",
path,
})

expect(result.success).toBe(false)
expect(result.error).toContain("Invalid path")
expect(documentsListMock).not.toHaveBeenCalled()
},
)
})
14 changes: 9 additions & 5 deletions packages/tools/src/claude-memory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -805,11 +805,15 @@ export class ClaudeMemoryTool {
* Validate that path starts with /memories for security
*/
private isValidPath(path: string): boolean {
return (
(path.startsWith("/memories/") || path === "/memories") &&
!path.includes("../") &&
!path.includes("..\\")
)
if (!(path.startsWith("/memories/") || path === "/memories")) {
return false
}
if (path.includes("..\\")) {
return false
}
// Reject any parent-directory segment, including trailing "/.." which
// the previous "../" substring check missed (e.g. "/memories/..").
return !path.split("/").some((segment) => segment === "..")
}
}

Expand Down