fix: handle disallowed localStorage, simplify script injection - #167
Open
WarningImHack3r wants to merge 3 commits into
Open
fix: handle disallowed localStorage, simplify script injection#167WarningImHack3r wants to merge 3 commits into
WarningImHack3r wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: dfbec66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
I ALWAYS forget
WarningImHack3r
commented
Jul 8, 2026
| const rootEl = document.documentElement; | ||
| const mode = localStorage.getItem(modeStorageKey) ?? defaultMode; | ||
| const theme = localStorage.getItem(themeStorageKey) ?? defaultTheme; | ||
| let mode: string = defaultMode; |
Author
There was a problem hiding this comment.
I didn't use local in this function as I assumed printing a function with toString() would break the import
Also, I don't know about TypeScript types in printed functions, but it looks like JS removes them
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166
Inspired by sveltejs/svelte.dev#2081, implementation based on sveltejs/svelte.dev#2082
I also simplified the script injection part in the component: tell me if it's okay both in terms of implementation and PR scope