fix: add queryConfigEnabled to type-cast mappings#10878
Open
mixelburg wants to merge 2 commits into
Open
Conversation
mixelburg
force-pushed
the
fix/queryConfigEnabled-mapping
branch
from
77c31e4 to
51e3754
Compare
queryConfigEnabled was defined in defaults.js but missing from src/core/config/type-cast/mappings.js, meaning the option was not type-cast when provided via URL query parameters or constructor. Fixes swagger-api#10744
mixelburg
force-pushed
the
fix/queryConfigEnabled-mapping
branch
from
51e3754 to
bffc57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
queryConfigEnabledoption was defined insrc/core/config/defaults.jsbut was missing fromsrc/core/config/type-cast/mappings.js, meaning the option was not type-cast when provided via URL query parameters or constructor configuration.Changes
Added
queryConfigEnabledentry to the type-cast mappings object withbooleanTypeCasteranddefaultValuefromdefaultOptions.queryConfigEnabled.Fixes #10744