fix: render arrays with boolean false item schemas#10922
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guard the array item schema type lookup so JSON Schema boolean schemas such as
items: falsedo not throw while rendering nested array parameters.Adds a regression test for an OpenAPI 3.1-style tuple schema using
prefixItemswithitems: false.Motivation and Context
Fixes #10921.
OpenAPI 3.1 uses JSON Schema 2020-12, where tuple schemas can disallow additional items with
items: false. Rendering the parameter form reachedschemaItems?.get("type"); because boolean schemas do not implementget, the endpoint details crashed instead of rendering.How Has This Been Tested?
npm run test:unit -- --runTestsByPath test/unit/core/plugins/json-schema-5/components/json-schema-form.jsx --runInBand./node_modules/.bin/eslint --quiet src/core/plugins/json-schema-5/components/json-schema-components.jsx test/unit/core/plugins/json-schema-5/components/json-schema-form.jsxgit diff --checkScreenshots (if appropriate):
N/A
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests