Repository navigation
revert: restore the pre-#155 SQLite lock behavior - #163
Merged
Merged
Conversation
This reverts commit 8cff350. Reason: the multi-writer failure in data/opencode-fixed-binary-155/report.md. Refs #162 Claude-Session: https://claude.ai/code/session_019PSxF9tfYzQesA13oxDTHe
Author
|
Session stamp (claim record)
|
brentyates-swx
added a commit
that referenced
this pull request
Oct 10, 2026
Brings in the #155 revert (#163) before this PR merges. The reviewed head 394ec55 stays on the first parent. Claude-Session: https://claude.ai/code/session_015hTsruVJZ4rc4nVuPj1KgU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #155
Refs #162
This reverts
8cff3506(#155, "fix(core): restore the SQLite lock-wait window") onswxtch.Why. Under concurrent writers,
8cff3506drops more accepted prompts than its parentbf5180afa0(#150). The report attributes the extra losses toSQLITE_BUSY_SNAPSHOT: #155 excludes that code from retry, so a stale-snapshot failure fails its prompt after the 204 has been returned. The diagnostic build behind that attribution is in the report and was not repeated for this PR. This PR restores the parent's behavior. The fix-forward is tracked in #162, and this PR does not attempt it.Tree identity
a0703354:git diff --stat bf5180afa0 a0703354is empty.bf5180afa0^{tree}=a0703354^{tree}=164199bcea117031172486bbe1a0c5bccaedff10.a97b0577changes onlyCHANGESET.md, adding this PR's entry.Multi-writer comparison
Four
opencode serveprocesses per set, one scratch DB per set, heavy load (8 rounds x 24 sessions per server x 32 threads; 768 accepted prompts per run). Short = accepted prompts (HTTP 204) with no persisted user message.a070335486622785a0703354bf5180afa0703354bf5180af8cff3506. That build was not re-measured here.SQLITE_BUSYorLockTimeoutErrorcause.Tests
packages/core:sqlite-busy, 20 pass, 0 fail.packages/opencode: lock consumers (httpapi-error-middleware,processor-effect), 36 pass, 0 fail.Changeset
a97b0577adds this PR's entry under "Fork changes" inCHANGESET.md.script/changeset-check.tspasses for #163 with CI's environment.Full evidence:
data/opencode-revert-155/report.mdin the fleet data directory (not in this repo).🤖 Generated with Claude Code