1047330: Fixed chart accessibility, b-unit, leak issues. - #44
Open
Yokesh-SF4393 wants to merge 4 commits into
Open
1047330: Fixed chart accessibility, b-unit, leak issues.#44Yokesh-SF4393 wants to merge 4 commits into
Yokesh-SF4393 wants to merge 4 commits into
Conversation
This was referenced Aug 24, 2026
Keerthivasan-Ramamoorthy
previously approved these changes
Aug 24, 2026
PrinceOliver
previously approved these changes
Aug 25, 2026
Sittiq3586
suggested changes
Aug 25, 2026
Sittiq3586
left a comment
There was a problem hiding this comment.
Major concerns (5) — must address before merge:
- Memory fix is incomplete — deprecated static caches remain in fallback path for non-SfChart callers and sibling chart components must be checked separately
- Performance regression — per-instance caching re-measures per chart instead of once per process (consider bounded LRU)
- Thread-safety bug — _requestedFontKeys is List, not concurrent
- First-tooltip narration race — setTimeout(…, 0) defers ARIA attributes; first update may reach AT without them
- Deprecated member call sites — fallback paths still reference the obsolete static members; verify TreatWarningsAsErrors won't break the build
Minor concerns (5):
- 3 XML-doc syntax errors (will break doc-gen)
- Bundled ChartAxisRenderer rendering fix should be a separate PR
- Casings diverge between samples and tests
- _tooltipLiveObserver doc-comment clarify-singleton intent
- Validator XML doc should note case-insensitivity
| /// It will be removed in a future major version. | ||
| /// </para> | ||
| /// </remarks> | ||
| [System.Obsolete("Use SfChart._fontSizeCache and MeasureText(string, ChartFontOptions, object) overload instead. This static cache causes memory leaks on long-lived Blazor Server hosts.")] |
There was a problem hiding this comment.
Remove the obsolete properties, if it doesn't used.
Collaborator
Author
There was a problem hiding this comment.
Removed obsolete properties
| /// <param name="character">The character to measure.</param> | ||
| /// <param name="font">The font settings used during measurement.</param> | ||
| /// <returns>The measured character size.</returns> | ||
| private static Size GetCharSize(object chart, char character, ChartFontOptions font) |
There was a problem hiding this comment.
The new methods you were implemented was also presented in the class, you can revamp the methods to reduce multiple methods.
Collaborator
Author
There was a problem hiding this comment.
Revamped the methods.
Yokesh-SF4393
dismissed stale reviews from PrinceOliver and Keerthivasan-Ramamoorthy
via
August 25, 2026 11:46
6074d47
This reverts commit 6074d47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
Need to fix the accessibility issue - aria role issues, tooltip narrator issue, rectangle/path focus issues, release b-unit test cases failures, memory leak issues.
Root cause
Solution description
Review changes:
Code Studio usage(Mandatory)
Code Studio used in this PR/MR?
If
Yes: Primary use (choose one)Outcome
If “Cost time” explain in short (1 or 2 lines):
Impact assessment
Reason for not identifying earlier
This was recently identified by testing the with MS audit and AI agents. Now identified and fixed.
Areas tested against this fix
Breaking changes
breaking-issue)If yes, provide breaking commit details link and migration guidance.
Regression testing
Action taken to prevent recurrence
Automation status
Cross-platform verification
Related issues
Is this issue present in EJ2 or other components?
needs-attention-coreteam)Output screenshots
Post the output screenshots if a UI is affected or added due to this bug.
API changes
Performance verification
Reviewer Checklist