refactor: polish logs helpers#969
Open
ovitrif wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #963
This PR:
fix/logs-spam-and-size, so support uploads use the archive base name while local sharing keeps the.zipfile name.Description
The support-log flow now separates upload archive naming from local ZIP file naming, avoiding repeated
.zipsuffix handling while keeping the local share file explicit.The refactor keeps the production flow behavior in
LogsRepoandLogSaverImpl, but moves the small pure pieces into testable helpers. That gives the log retention and ZIP-trimming behavior direct coverage without needing full repository or logger lifecycle setup.Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
app/src/test/java/to/bitkit/repositories/LogsRepoTest.kt.app/src/test/java/to/bitkit/utils/LogSaverImplTest.kt../gradlew compileDevDebugKotlin../gradlew testDevDebugUnitTest../gradlew detekt.git diff --check origin/master...HEAD.